On Tue, Feb 18, 2020 at 08:10:25PM +0800, Longpeng(Mike) wrote: > { > - pgd_t *pgd; > - p4d_t *p4d; > - pud_t *pud; > - pmd_t *pmd; > + pgd_t *pgdp; > + p4d_t *p4dp; > + pud_t *pudp, pud; > + pmd_t *pmdp, pmd; Renaming the variables as part of a fix is a really bad idea. It obscures the actual fix and makes everybody's life harder. Plus, it's not even renaming to follow the normal convention -- there are only two places (migrate.c and gup.c) which follow this pattern in mm/ while there are 33 that do not.