On 2/11/20 9:25 PM, Li Xinhai wrote: > On 2020-02-12 at 11:21 HORIGUCHI NAOYA(堀口 直也) wrote: >> On Mon, Feb 10, 2020 at 09:19:48AM -0800, Mike Kravetz wrote: >>> On 1/30/20 5:33 PM, Li Xinhai wrote: >> ... >>>> >>>> Signed-off-by: Li Xinhai <lixinhai.lxh@xxxxxxxxx> >>>> Cc: Michal Hocko <mhocko@xxxxxxxx> >>>> Cc: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >>>> Cc: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> >>>> Cc: linux-man <linux-man@xxxxxxxxxxxxxxx> >>> >>> Hello Naoya, >>> >>> Do you have any thoughts on this? In previous discussions you suggested this >>> approach of removing the special casing for hugetlb pages. The code looks >>> good to me and patch is fine with commmit message modification. Just wanted >>> to get your opinion. >> >> Hi Mike, Xinhai, >> >> The suggested change looks good to me, too. >> >> Thanks, >> Naoya Horiguchi > > Naoya, thanks for inspecting the change! Can you please send V2 of patch with an updated commit message. I would like the section that which lists the impact to "users using MPOL_MF_STRICT alone" to say something like this: If MPOL_MF_STRICT alone was previously used, hugetlb pages not following the memory policy would not cause an EIO error. After this change, hugetlb pages are treated like all other pages. If MPOL_MF_STRICT alone is used and hugetlb pages do not follow memory policy an EIO error will be returned. -- Mike Kravetz
