On 02/11/20 at 04:41pm, Andrew Morton wrote: > On Tue, 11 Feb 2020 07:07:41 +0800 Wei Yang <richardw.yang@xxxxxxxxxxxxxxx> wrote: > > > On Mon, Feb 10, 2020 at 02:15:51PM +0800, Baoquan He wrote: > > >On 02/10/20 at 02:09pm, Baoquan He wrote: > > >> On 02/09/20 at 09:56pm, Andrew Morton wrote: > > >> > On Mon, 10 Feb 2020 13:40:27 +0800 Baoquan He <bhe@xxxxxxxxxx> wrote: > > >> > > > >> > > Hi Andrew, > > >> > > > > >> > > On 02/09/20 at 09:32pm, Andrew Morton wrote: > > >> > > > On Tue, 04 Feb 2020 11:25:48 +0000 bugzilla-daemon@xxxxxxxxxxxxxxxxxxx wrote: > > >> > > > > > >> > > > > https://bugzilla.kernel.org/show_bug.cgi?id=206401 > > >> > > > > > > >> > > > > > >> > > > An oops during mem hotadd. Could someone please take a look when > > >> > > > convenient? > > >> > > > > >> > > This has been addressed by Wei Yang's patch, please check it here: > > >> > > > > >> > > http://lkml.kernel.org/r/20200209104826.3385-7-bhe@xxxxxxxxxx > > >> > > > > >> > > > >> > hm, OK, thanks. It's unfortunate that a 5.5 fix is buried in a > > >> > six-patch series which is still in progress! Can we please merge that > > >> > as a standalone fix with a cc:stable, Fixes:, etc? > > > > > >Maybe can add Fixes tag as follow when merge: > > > > > >Fixes: ba72b4c8cf60 ("mm/sparsemem: support sub-section hotplug") > > > > > The reporter (cc'ed here) is still seeing issues: > https://bugzilla.kernel.org/show_bug.cgi?id=206401 > > Could we please continue this investigation via emailed reply-to-all, > rather than via the bugzilla interface? Yes, people prefer mailing list to discuss issues. Hi T.Kabe, Could you provide the call trace again after below patch is applied? The comment #9 in bugzilla is not very clear to me. mm/sparsemem: pfn_to_page is not valid yet on SPARSEMEM http://lkml.kernel.org/r/20200209104826.3385-7-bhe@xxxxxxxxxx And, as you said, applying above patch, and do not call __free_pages_core() in generic_online_page() will work. I doubt it, because without __free_pages_core(), your added pages are not added into buddy for managing. I think we should make clear this problem firstly, in order not to introduce new problem by improper work around, then check next. Thanks Baoquan
