Re: [PATCH] slub: always align cpu_slab to honor cmpxchg_double requirement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Jun 2011, Chris Metcalf wrote:

> On an architecture without CMPXCHG_LOCAL but with DEBUG_VM enabled,
> the VM_BUG_ON() in __pcpu_double_call_return_bool() will cause an early
> panic during boot unless we always align cpu_slab properly.
> 
> In principle we could remove the alignment-testing VM_BUG_ON() for
> architectures that don't have CMPXCHG_LOCAL, but leaving it in means
> that new code will tend not to break x86 even if it is introduced
> on another platform, and it's low cost to require alignment.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

> ---
> This needs to be pushed for 3.0 to allow arch/tile to boot.
> I'm happy to push it but I assume it would be better coming
> from an mm or percpu tree.  Thanks!
> 

Should also be marked for stable for 2.6.39.x, right?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]