On 03.02.20 21:32, Tyler Sanderson wrote: > There were apparently good reasons for moving away from OOM notifier > callback: > https://lkml.org/lkml/2018/7/12/314 > https://lkml.org/lkml/2018/8/2/322 > > In particular the OOM notifier is worse than the shrinker because: The issue is that DEFLATE_ON_OOM is under-specified. > > 1. It is last-resort, which means the system has already gone through > heroics to prevent OOM. Those heroic reclaim efforts are expensive > and impact application performance. That's *exactly* what "deflate on OOM" suggests. Assume you are using virtio-balloon for some weird way of memory hotunplug (which is what some people do) and you want to minimize the footprint of your guest. Then you really only want to give the guest more memory (or rather, let it take back memory automatically in this case) in case it really needs more memory. It should try to reclaim first. Under-specified. > 2. It lacks understanding of NUMA or other OOM constraints. Ballooning in general lacks the understanding of NUMA. > 3. It has a higher potential for bugs due to the subtlety of the > callback context. While that is a valid point, it doesn't explain why existing functionality is changed. Personally, I think DEFLATE_ON_OOM should never have been introduced (at least not in this form). -- Thanks, David / dhildenb
