2011/6/1 Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>: > Please be more polite to other people. After a197b59ae6 all allocations > with GFP_DMA set on nodes without ZONE_DMA fail nearly silently (only > one warning during bootup is emited, no matter how many things fail). > This is a very crude change on behaviour. To be more civil, instead of > failing emit noisy warnings each time smbd. tries to allocate a GFP_DMA > memory on non-ZONE_DMA node. > > This change should be reverted after one or two major releases, but > we should be more accurate rather than hoping for the best. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> > Cc: David Rientjes <rientjes@xxxxxxxxxx> > Cc: Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> > Cc: Mel Gorman <mel@xxxxxxxxx> > Cc: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > Cc: Rik van Riel <riel@xxxxxxxxxx> > Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Instaed of, shouldn't we revert a197b59ae6? Some arch don't have DMA_ZONE at all. and a197b59ae6 only care x86 embedded case. If we accept your patch, I can imagine other people will claim warn foold is a bug. ;) However, I think, you should explain which platform and drivers hit this breakage. Otherwise developers can't learn which platform should care. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>