On 31.01.2020 19:18, Michal Hocko wrote: > On Fri 31-01-20 19:08:49, Kirill Tkhai wrote: >> mm: Allocate shrinker_map on appropriate NUMA node >> >> From: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> >> >> Despite shrinker_map may be touched from any cpu >> (e.g., a bit there may be set by a task running >> everywhere); kswapd is always bound to specific >> node. So, we will allocate shrinker_map from >> related NUMA node to respect its NUMA locality. >> Also, this follows generic way we use for allocation >> memcg's per-node data. > > I would just drop the last sentence. I mean we allocate memcg->nodeinfo from specific node, so shrinker_map also should follow this rule. Though, I have no objections to remove this on patch merge. >> Signed-off-by: Kirill Tkhai <ktkhai@xxxxxxxxxxxxx> > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> Thanks, Kirill.