Hi Dave, On 27/01/20 9:12 pm, Dave Hansen wrote: > > How have you tested this patch (and the whole series for that matter)? > I replaced the second patch with this one and did a build test. Till v16, I had tested the whole series (build + run) on both a POWER8 system (with 4K and 64K page sizes) and a Skylake SP system but for x86_64 only. Following that, I could only do a build test locally on my laptop for i386 and x86_64 on my laptop as I did not have access to the Skylake system anymore. This is how I tested the build process: $ cd linux $ make -C tools/testing/selftests ... make[1]: Entering directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' ... gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 ... $ make -C tools/testing/selftests clean $ make -C tools/testing/selftests/vm make: Entering directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' make --no-builtin-rules ARCH=x86_64 -C ../../../.. headers_install make[1]: Entering directory '/home/sandipan/.devel/linux' INSTALL ./usr/include make[1]: Leaving directory '/home/sandipan/.devel/linux' ... gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 ... $ make -C tools/testing/selftests/vm clean $ make -C tools/testing/selftests/vm protection_keys make: Entering directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 make: Leaving directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' $ make -C tools/testing/selftests/vm clean $ make -C tools/testing/selftests/vm protection_keys_32 make: Entering directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 make: Leaving directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' $ make -C tools/testing/selftests/vm protection_keys_64 make: Entering directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 make: Leaving directory '/home/sandipan/.devel/linux/tools/testing/selftests/vm' $ make -C tools/testing/selftests/vm clean $ cd tools/testing/selftests/vm $ make make --no-builtin-rules ARCH=x86_64 -C ../../../.. headers_install make[1]: Entering directory '/home/sandipan/.devel/linux' INSTALL ./usr/include make[1]: Leaving directory '/home/sandipan/.devel/linux' ... gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 ... $ make clean $ make protection_keys gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 $ make clean $ make protection_keys_32 gcc -Wall -I ../../../../usr/include -no-pie -m32 protection_keys.c -lrt -lrt -ldl -lm -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_32 $ make protection_keys_64 gcc -Wall -I ../../../../usr/include -no-pie -m64 protection_keys.c -lrt -lrt -ldl -o /home/sandipan/.devel/linux/tools/testing/selftests/vm/protection_keys_64 - Sandipan
