On Tue, May 31, 2011 at 8:23 AM, KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 20c18b7..72cf857 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.c >> @@ -461,7 +461,11 @@ void refresh_cpu_vm_stats(int cpu) >> p->expire = 3; >> #endif >> } >> + >> +#ifndef CONFIG_PREEMPT >> cond_resched(); >> +#endif >> + > > In general, we should avoid #ifdef CONFIG_PREEMPT for maintainancebility as far as possible. > Is there any observable benefit? Can you please demonstrate it? > On my system I'm not sure whether it shows demonstratable benefit or not. Although, I try. It will be helpful if you give me a hint about how to measure its benefit. Thanks, Rakib > > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href