Re: [PATCH v2 1/6] fs/readdir: Fix filldir() and filldir64() use of user_access_begin()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[ Sorry about HTML crud, on mobile right now ]

On Wed, Jan 22, 2020, 09:52 Christophe Leroy <christophe.leroy@xxxxxx> wrote:

-       struct linux_dirent __user * dirent;
+       struct linux_dirent __user * dirent, *dirent0;

Patch looks better, but those names are horrid.

Please just use "prev" for the previous dirent, and leave the current one as "dirent".

I think that's going to be a lot more legible. But no numbering.

      Linus

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux