On Wed 22-01-20 08:40:12, Wei Yang wrote: > On Tue, Jan 21, 2020 at 09:43:52AM +0100, Michal Hocko wrote: > >On Tue 21-01-20 09:22:00, Wei Yang wrote: > >> On Mon, Jan 20, 2020 at 11:02:03AM +0100, Michal Hocko wrote: > >> >On Sun 19-01-20 11:06:35, Wei Yang wrote: > >> >> When page is not successfully queued for migration, we would move pages > >> >> on pagelist immediately. Actually, this could be done in the next > >> >> iteration by telling it we need some help. > >> >> > >> >> This patch adds a new variable need_move to be an indication. After > >> >> this, we only need to call move_pages_and_store_status() twice. > >> > > >> >No! Not another iterator. There are two and this makes the function > >> >quite hard to follow already. We do not want to add a third one. > >> > > >> > >> Two iterators here are? I don't get your point. > > > >i is the main iterator to process the whole imput. start is another one > >to control the batch to migrate. We do not need/want more. More clear? > > Yes, more clear. Great > I hope you are angry with me. Sorry for my poor English. Heh, not at all. -- Michal Hocko SUSE Labs
