On Tue, Jan 21, 2020 at 10:19:38AM +0530, Anshuman Khandual wrote: > > >On 01/20/2020 06:06 PM, Wei Yang wrote: >> On Mon, Jan 20, 2020 at 12:13:38PM +0530, Anshuman Khandual wrote: >>> >>> >>> On 01/20/2020 08:34 AM, Wei Yang wrote: >>>> During free and new page, we did some check on the status of page >>>> struct. There is some common part, just extract them. >>> >>> Makes sense. >>> >>>> >>>> Besides this, this patch also rename two functions to keep the name >>>> convention, since free_pages_check_bad/free_pages_check are counterparts >>>> of check_new_page_bad/check_new_page. >>> >>> This probably should be in a different patch. >>> >> >> In v1, they are in two separate patches. While David Suggest to merge it. >> >> I am not sure whether my understanding is correct. > >Keeping code refactoring and renaming separate is always better >but its okay, will leave it upto you. > Agree with you :-) Maybe I misunderstand David. Will split it in next version. -- Wei Yang Help you, Help me
