On Fri 17-01-20 10:05:12, Qian Cai wrote: > > > > On Jan 17, 2020, at 9:39 AM, Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > Thanks a lot. Having it in a separate patch would be great. > > I was thinking about removing that WARN together in this v5 patch, > so there is less churn to touch the same function again. However, I > am fine either way, so just shout out if you feel strongly towards a > separate patch. I hope you meant moving rather than removing ;). The warning is useful because we shouldn't see unmovable pages in the movable zone. And a separate patch makes more sense because the justification is slightly different. We do not want to have a way for userspace to trigger the warning from userspace - even though it shouldn't be possible, but still. Only the offlining path should complain. -- Michal Hocko SUSE Labs
