On Wed 2020-01-15 12:16:17, Qian Cai wrote: > > > > On Jan 15, 2020, at 12:02 PM, Petr Mladek <pmladek@xxxxxxxx> wrote: > > > > On Wed 2020-01-15 06:49:03, Qian Cai wrote: > >> > >> > >>> On Jan 15, 2020, at 4:52 AM, Petr Mladek <pmladek@xxxxxxxx> wrote: > >>> > >>> I could understand that Michal is against hack in -mm code that > >>> would just hide a false positive warning. > >> > >> Well, I don’t have any confidence to say everything this patch is > >> trying to fix is false positives. > > > > You look at this from a wrong angle. AFAIK, all lockdep reports pasted > > in the below mentioned thread were false positives. Now, this patch > > complicates an already complicated -mm code to hide the warning > > and fix theoretical problems. > > What makes you say all of those are false positives? I have to admit that the 3 provided lockdep reports really looked suspicious. I must have somehow missed/forgot about them. If the last proposed change removes them and is acceptable for -mm people then it looks like a reasonable solution. Best Regards, Petr
