On Tue, 14 Jan 2020 20:39:33 +0800 Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> wrote: > commit 1b2ffb7896ad ("[PATCH] Zone reclaim: Allow modification of zone reclaim behavior")' > defined RECLAIM_OFF/RECLAIM_ZONE, but never use them, so better to remove them. > > ... > > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -4126,8 +4126,6 @@ static int __init kswapd_init(void) > */ > int node_reclaim_mode __read_mostly; > > -#define RECLAIM_OFF 0 > -#define RECLAIM_ZONE (1<<0) /* Run shrink_inactive_list on the zone */ > #define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */ > #define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */ --- a/mm/vmscan.c~mm-vmscan-remove-unused-reclaim_off-reclaim_zone-fix +++ a/mm/vmscan.c @@ -4118,8 +4118,8 @@ module_init(kswapd_init) */ int node_reclaim_mode __read_mostly; -#define RECLAIM_WRITE (1<<1) /* Writeout pages during reclaim */ -#define RECLAIM_UNMAP (1<<2) /* Unmap pages during reclaim */ +#define RECLAIM_WRITE (1<<0) /* Writeout pages during reclaim */ +#define RECLAIM_UNMAP (1<<1) /* Unmap pages during reclaim */ /* * Priority for NODE_RECLAIM. This determines the fraction of pages _ This might be a bit picky ;)