On Mon, Jan 13, 2020 at 2:14 PM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote: > > +extern void hugetlb_cgroup_uncharge_counter(struct page_counter *p, > > + unsigned long nr_pages, > > + struct cgroup_subsys_state *css); > > + > > Do we need a corresponding stub for the !CONFIG_CGROUP_HUGETLB case? > Not necessary AFAICT because the code is only called from code guarded by CONFIG_CGROUP_HUGETLB. Addressing comments from you and David in v10 shortly. Thanks for the review!