On 1/12/20 2:39 PM, Pavel Begunkov wrote: > On 10/01/2020 18:47, Jens Axboe wrote: >> This adds support for doing madvise(2) through io_uring. We assume that >> any operation can block, and hence punt everything async. This could be >> improved, but hard to make bullet proof. The async punt ensures it's >> safe. >> > I don't like that it share structs/fields names with fadvise. E.g. madvise's > context is called struct io_fadvise. Could it at least have fadvise_advice filed > in struct io_uring_sqe? io_uring parts of the patchset look good. > > Reviewed-by: Pavel Begunkov <asml.silence@xxxxxxxxx> Thanks, I can add the separate union, not a big deal. -- Jens Axboe
