Re: [PATCH 3/3] mm/migrate: add stable check in migrate_vma_insert_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ralph Campbell <rcampbell@xxxxxxxxxx>
Subject: Re: [PATCH 3/3] mm/migrate: add stable check in migrate_vma_insert_page()
From: Christoph Hellwig <hch@xxxxxx>
Date: Wed, 8 Jan 2020 08:12:45 +0100
Cc: linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jerome Glisse <jglisse@xxxxxxxxxx>, John Hubbard <jhubbard@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Jason Gunthorpe <jgg@xxxxxxxxxxxx>, Bharata B Rao <bharata@xxxxxxxxxxxxx>, Michal Hocko <mhocko@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20200107211208.24595-4-rcampbell@nvidia.com>
References: <20200107211208.24595-1-rcampbell@nvidia.com> <20200107211208.24595-4-rcampbell@nvidia.com>
User-agent: Mutt/1.5.17 (2007-11-01)

On Tue, Jan 07, 2020 at 01:12:08PM -0800, Ralph Campbell wrote:
> migrate_vma_insert_page() closely follows the code in:
>   __handle_mm_fault()
>     handle_pte_fault()
>       do_anonymous_page()

I wonder if we could share more code there?

Otherwise this looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH 0/3] mm/migrate: add missing check for stable
  - From: Ralph Campbell
- [PATCH 3/3] mm/migrate: add stable check in migrate_vma_insert_page()
  - From: Ralph Campbell

Prev by Date: Re: [PATCH 2/3] mm/migrate: clean up some minor coding style
Next by Date: Re: [PATCH v16 0/9] mm / virtio: Provide support for free page reporting
Previous by thread: [PATCH 3/3] mm/migrate: add stable check in migrate_vma_insert_page()
Next by thread: [PATCH 2/3] mm/migrate: clean up some minor coding style
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]

Powered by Linux