Re: [PATCH] mm: don't access vm_flags as 'int'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 26, 2011 at 7:53 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> 2011/5/26 KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>:
>> The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor
>> 'unsigned int'. This patch fixes such misuse.
>
> I applied this, except I also just made the executive decision to
> replace things with "vm_flags_t" after all.
>
> Which leaves a lot of "unsigned long" users that aren't converted, but
> right now it doesn't matter, and it can be converted piecemeal as
> people notice users..
>

This breaks kernel builds with CONFIG_HUGETLBFS=n. :-(

In file included from fs/proc/meminfo.c:2:0:
include/linux/hugetlb.h:195:3: error: expected declaration specifiers
or ‘...’ before ‘vm_flags_t’
  CC      drivers/ata/libata-pmp.o
make[2]: *** [fs/proc/meminfo.o] Fehler 1
make[1]: *** [fs/proc] Fehler 2
make: *** [fs] Fehler 2
make: *** Warte auf noch nicht beendete Prozesse...


-- 
Thanks,
//richard

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]