On Tue 17-12-19 15:09:21, Chris Down wrote: [...] > (Side note: I'm moderately baffled that a tightly scoped __maybe_unused is > considered sinister but somehow disabling -Wunused-function is on the table > :-)) Well, I usually do not like to see __maybe_unused because that is prone to bit-rot and loses its usefulness. Looking into the recent git logs most -Wunused-function led to the code removal (which is really good but the compiler is likely to do that already so the overall impact is not that large) or more ifdefery. I do not really see many instance of __maybe_unused. -- Michal Hocko SUSE Labs
