[please cc maintainers] On Wed, Dec 11, 2019 at 06:59:19PM +0800, Hillf Danton wrote: > Round robin is needed only for unbound workqueue and wq_unbound_cpumask > has nothing to do with standard workqueues, so we have to select cpu in > case of WORK_CPU_UNBOUND also with workqueue type taken into account. Good catch. I'd include something like this in the changelog. Otherwise, work queued on a bound workqueue with WORK_CPU_UNBOUND might not prefer the local CPU if wq_unbound_cpumask is non-empty and doesn't include that CPU. With that you can add Reviewed-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>