(2011/05/24 18:20), Minchan Kim wrote: > On Tue, May 24, 2011 at 6:09 PM, KOSAKI Motohiro > <kosaki.motohiro@xxxxxxxxxxxxxx> wrote: >>>>> Hmm, If I understand your code correctly, unprivileged process can get >>>>> a score 1 by 3% bonus. >>>> >>>> 3% bonus is for privileged process. :) >>> >>> OMG. Typo. >>> Anyway, my point is following as. >>> If chose_point is 1, it means root bonus is rather big. Right? >>> If is is, your patch does second loop with completely ignore of bonus >>> for root privileged process. >>> My point is that let's not ignore bonus completely. Instead of it, >>> let's recalculate 1.5% for example. >> >> 1) unpriviledged process can't get score 1 (because at least a process need one >> anon, one file and two or more ptes). >> 2) then, score=1 mean all processes in the system are privileged. thus decay won't help. >> >> IOW, never happen privileged and unprivileged score in this case. > > I am blind. Thanks for open my eyes, KOSAKI. No. Your review is very cute. Thank you for attempting this! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>