On Mon, Dec 2, 2019 at 2:33 PM Marco Elver <elver@xxxxxxxxxx> wrote: > > On Fri, 22 Nov 2019 at 12:27, <glider@xxxxxxxxxx> wrote: > > > > KMSAN doesn't currently support lock debugging, causing the kernel to > > enter infinite recursion at boot time. > > See https://github.com/google/kmsan/issues/57. > > > > Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx> > > Cc: Eric Biggers <ebiggers@xxxxxxxxxx> > > Cc: Qian Cai <cai@xxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > Cc: Harry Wentland <harry.wentland@xxxxxxx> > > Cc: Vegard Nossum <vegard.nossum@xxxxxxxxxx> > > Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx> > > Cc: linux-mm@xxxxxxxxx > > > > --- > > This patch is part of "kmsan: Kconfig changes to disable options > > incompatible with KMSAN", which was split into smaller pieces. > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 75c36318943d..a3f6f5d68593 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)" > > config LOCK_DEBUGGING_SUPPORT > > bool > > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT > > + # KMSAN is incompatible with lockdep, > > + # see https://github.com/google/kmsan/issues/57. > > + depends on !KMSAN > > default y > > > > config PROVE_LOCKING > > > > Change-Id: I4f97edc8a02d8ca208fc914e55e8f0c23d74eac8 > > --- > > lib/Kconfig.debug | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index 75c36318943d..a3f6f5d68593 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -1068,6 +1068,9 @@ menu "Lock Debugging (spinlocks, mutexes, etc...)" > > config LOCK_DEBUGGING_SUPPORT > > bool > > depends on TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT > > + # KMSAN is incompatible with lockdep, > > + # see https://github.com/google/kmsan/issues/57. > > Does it make sense to get this working? Or rather, is it feasible to > get working? If not, I would just remove the reference to the Github > issue, and declare that KMSAN is incompatible with lockdep. Agreed. At this point I don't really know why KMSAN and lockdep don't play well together, but I'm not expecting anyone to use them together either. > > + depends on !KMSAN > > default y > > > > config PROVE_LOCKING > > -- > > 2.24.0.432.g9d3f5f5b63-goog > > -- Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Straße, 33 80636 München Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
