On Thu, Nov 28, 2019 at 09:03:21AM +0800, Wei Yang wrote: > The check here is to guarantee pvmw->address iteration is limited in one > page table boundary. To be specific, here the address range should be in > one PMD_SIZE. > > If my understanding is correct, this check is already done in the above > check: > > address >= __vma_address(page, vma) + PMD_SIZE > > The boundary check here seems not necessary. > > Signed-off-by: Wei Yang <richardw.yang@xxxxxxxxxxxxxxx> NAK. THP can be mapped with PTE not aligned to PMD_SIZE. Consider mremap(). > Test: > more than 48 hours kernel build test shows this code is not touched. Not an argument. I doubt mremap(2) is ever called in kernel build workload. -- Kirill A. Shutemov
