On Tue 26-11-19 22:51:30, Yafang Shao wrote: > On Tue, Nov 26, 2019 at 10:45 PM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > On Tue 26-11-19 22:25:27, Yafang Shao wrote: > > > On Tue, Nov 26, 2019 at 9:16 PM Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > > > > > > > On Tue 26-11-19 08:02:49, Yafang Shao wrote: > > > > > There's one case that the processes in a memcg are all exit (due to OOM > > > > > group or some other reasons), but the file page caches are still exist. > > > > > These file page caches may be protected by memory.min so can't be > > > > > reclaimed. If we can't success to restart the processes in this memcg or > > > > > don't want to make this memcg offline, then we want to drop the file page > > > > > caches. > > > > > The advantage of droping this file caches is it can avoid the reclaimer > > > > > (either kswapd or direct) scanning and reclaiming pages from all memcgs > > > > > exist in this system, because currently the reclaimer will fairly reclaim > > > > > pages from all memcgs if the system is under memory pressure. > > > > > The possible method to drop these file page caches is setting the > > > > > hard limit of this memcg to 0. Unfortunately this may invoke the OOM killer > > > > > and generates lots of misleading outputs, that should not happen. > > > > > > > > I disagree that the output is misleading. Quite contrary, it provides a > > > > useful lead on the unreclaimable memory. > > > > > > > > > > We can show the unreclaimable memory independently, rather than print > > > the full oom output. > > > OOM killer is used to kill process, why do we invoke it when there's > > > no process ? > > > What's the advantage of doing it ? > > > > Consistency. > > > > If there are tasks, we invoke the OOM killer to try to kill the tasks. > If there're no tasks, we just try to free the reclaimable pages. The fact that the oom killer has been invoked implies there is _no_ reclaimable memory. Full stop. Anyway I am getting a bit tired to repeat myself so I am not continuing in this discussion. I have provided my feedback to your patch, please try to think harder about it. If you have real life usecases which cannot work properly with the existing functionality and APIs then bring them up. -- Michal Hocko SUSE Labs
