On Sun 24-11-19 16:10:53, David Rientjes wrote: [...] > So my question would be: if we know the previous behavior that allowed > excessive swap and recalling into compaction was deemed harmful for the > local node, why do we now believe it cannot be harmful if done for all > system memory? I have to say that I got lost in your explanation. I have already pointed this out in a previous email you didn't reply to. But the main difference to previous __GFP_THISNODE behavior is that it is used along with __GFP_NORETRY and that reduces the overall effort of the reclaim AFAIU. If that is not the case then please be _explicit_ why. Having test results from Andrea would be really appreciated of course but he seems to be too busy to do that (or maybe not interested anymore). I do not see any real reason to hold on this patch based on hand waving though. So either we have some good reasoning to argue against the patch or a good testing results or we should go ahead. As things stand right now, THP success rate went down after your last changes for _very simple_ workloads. This needs addressing which I hope we do agree on. -- Michal Hocko SUSE Labs
