在 2019/11/16 下午2:31, Shakeel Butt 写道: > On Fri, Nov 15, 2019 at 7:15 PM Alex Shi <alex.shi@xxxxxxxxxxxxxxxxx> wrote: >> We need a irqflags vaiable to save state when do irqsave action, declare >> it here would make code more clear/clean. >> >> Rong Chen <rong.a.chen@xxxxxxxxx> reported the 'irqflags' variable need >> move to the tail of lruvec struct otherwise it causes 18% regressions of >> vm-scalability testing on his machine. So add the flags and lru_lock to >> both near struct tail, even I have no clue of this perf losing. > Regressions compared to what? Also no need to have a separate patch. > Thanks for question, Shakeel, I will change the commit log and mention the original place: the head of lruvec struct. As to the folding, the 3rd is already toooo long. May I leave it here to relief a littel bit burden on reading? Thanks Alex
