On 14.11.19 10:08, Michael Ellerman wrote:
On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote:
When unloading the module, one gets
[ 548.188594] ------------[ cut here ]------------
[ 548.188596] Device 'cmm0' does not have a release() function, it is brok=
en and must be fixed. See Documentation/kobject.txt.
[ 548.188622] WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .devi=
ce_release+0xcc/0xf0
...
We only have on static fake device. There is nothing to do when
releasing the device (via cmm_exit).
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Cc: Vlastimil Babka <vbabka@xxxxxxx>
Cc: Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
Cc: Allison Randal <allison@xxxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: Arun KS <arunks@xxxxxxxxxxxxxx>
Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
Patches 1-10 applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/7d8212747435c534c8d564fbef4541a463c976ff
cheers
Thanks! I'll probably resend patch 11/12 to give it more attention and
to fixup one comment leftover in patch 11. I guess if we get ACKs these
two patch should also go via your tree to avoid collisions.
--
Thanks,
David / dhildenb
