Re: [PATCH V3 2/3] memcg: fix a routine for counting pages in node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On Thu, May 19, 2011 at 7:11 PM, Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx> wrote:
Acked-by: Daisuke Nishimura <nishimura@xxxxxxxxxxxxxxxxx>

This is a bugfix for memcg-reclaim-memory-from-nodes-in-round-robin-order.patch
in mmotm tree, so I think it would be better to note about it.

Sounds good, and I will add that comment in next post.

Thanks for reviewing it.

--Ying 

On Thu, 19 May 2011 10:32:39 -0700
Ying Han <yinghan@xxxxxxxxxx> wrote:

> The value for counter base should be initialized. If not,
> this returns wrong value.
>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
> ---
>  mm/memcontrol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index da183dc..e14677c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -679,7 +679,7 @@ static unsigned long
>  mem_cgroup_get_zonestat_node(struct mem_cgroup *mem, int nid, enum lru_list idx)
>  {
>       struct mem_cgroup_per_zone *mz;
> -     u64 total;
> +     u64 total = 0;
>       int zid;
>
>       for (zid = 0; zid < MAX_NR_ZONES; zid++) {
> --
> 1.7.3.1
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href="" href="mailto:dont@xxxxxxxxx" target="_blank">dont@xxxxxxxxx"> email@xxxxxxxxx </a>


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]