On 11/11/19 4:59 PM, Michael Ellerman wrote: > Michael Ellerman <mpe@xxxxxxxxxxxxxx> writes: >> >> Mike Kravetz <mike.kravetz@xxxxxxxxxx> writes: >>> On 11/5/19 2:19 AM, Stephen Rothwell wrote: > ... >>> From 4b3ab017e639e4e583fff801e6d8e6727b7877e8 Mon Sep 17 00:00:00 2001 >>> From: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >>> Date: Tue, 5 Nov 2019 15:12:15 -0800 >>> Subject: [PATCH] powerpc/mm: remove pmd_huge/pud_huge stubs and include >>> hugetlb.h >>> >>> This removes the power specific stubs created by commit aad71e3928be >>> ("powerpc/mm: Fix build break with RADIX=y & HUGETLBFS=n") used when >>> !CONFIG_HUGETLB_PAGE. Instead, it addresses the build break by >>> getting the definitions from <linux/hugetlb.h>. >>> >>> Signed-off-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> >>> --- >>> arch/powerpc/include/asm/book3s/64/pgtable-4k.h | 3 --- >>> arch/powerpc/include/asm/book3s/64/pgtable-64k.h | 3 --- >>> arch/powerpc/mm/book3s64/radix_pgtable.c | 1 + >>> 3 files changed, 1 insertion(+), 6 deletions(-) >> >> The two pgtable headers are included eventually by our top-level >> pgtable.h, and that is included by over 100 files. So I worry this is >> going to break the build somewhere in some obscure configuration. >> >> I'll push it through some test builds and see what happens. > > Seems OK, it didn't introduce any new build failures. > > Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > Thank you Michael! I'll add it to the other patch as a 'proper series' so this can be a requisite patch for the other. -- Mike Kravetz