On Fri, Nov 08, 2019 at 05:38:37PM +0800, Hillf Danton wrote: > > On Thu, 7 Nov 2019 09:57:48 -0500 Jerome Glisse wrote: > > > > I am not sure i follow ? Today we can not differentiate between GUP > > and regular get_page(), if you use some combination of specific fs > > and hardware you might get some BUG_ON() throws at you depending on > > how lucky/unlucky you are. We can not solve this without being able > > to differentiate between GUP and regular get_page(). Hence why John's > > patchset is the first step in the right direction. > > > What is the second one? And when? By who? Fix current BUG_ON() by not releasing buffer after write-back. Decide what to do for write back and then a page is pin. It will happens once we are done with pin changes and the infrastructure is in place. It will be done by John or others. > > If there is no GUP on a page then regular writeback happens as it has > > for years now so in absence of GUP i do not see any issue. > > > > > > > > still something where there is no agreement as far as i remember the > > > > outcome of the last discussion we had. I expect this will a topic > > > > at next LSF/MM or maybe something we can flush out before. > > > > > > These are the restraints we know > > > > > > A, multiple gup pins > > > B, mutual data corruptions > > > C, no break of existing use cases > > > D, zero copy > > > > ? What you mean by zero copy ? > > > Snippet that can be found at https://lwn.net/Articles/784574/ > > "get_user_pages() is a way to map user-space memory into the kernel's > address space; it will ensure that all of the requested pages have > been faulted into RAM (and locked there) and provide a kernel mapping > that, in turn, can be used for direct access by the kernel or (more > often) to set up zero-copy I/O operations. > > > > E, feel free to add > > > > > > then what is preventing an agreement like bounce page? > > > > There is 2 sides (AFAIR): > > - do not write back GUPed page and wait until GUP goes away to > > write them. But GUP can last as long as the uptime and we can > > loose data on power failure. > > - use a bounce page so that there is a chance we have some data > > on power failure > > > > > > > > Because page migrate and reclaim have been working for a while with > > > gup pin taken into account, detecting it has no priority in any form > > > over the agreement on how to make a witeback page stable. > > > > migrate just ignore GUPed page and thus there is no issue with migrate. > > writeback is a special case here because some filesystem need a stable > > page content and also we need to inhibit some fs specific things that > > trigger BUG_ON() in set_page_dirty*() > > > Which drivers so far have been snared by the BUG_ON()? Is there any > chance to fix them one after another? Otherwise what is making them > special (long-lived pin)? It is a race thing so it does not necesarily happens, the longer the pin the higher risk. It can only happens with some fs (i forgot which ones but you can go read the previous threads). It is easy to fix all we need to do is not release some fs structure of pinned pages after write-back. > After setting page dirty, is there any pending DMA transfer to the > dirty page? If yes, what is the point to do writeback for corrupted > data? If no, what is preventing the gup pin from being released? When user of GUP calls set_page_dirty() they _must_ be done with using the page and it is the case today AFAICT, so no pending DMA. The GUP pin is release after set_page_dirty() by all current users. Note that current users all do that once they are done and they can hold the pages for an _indifinite_ amount of time ie forever. They do dirty pages in their teardown code path. Hence the question that we need ti answer is what to do for dirty pages while they are GUPed. Note that a page can be set dirty while GUPed because CPU access can still happens and thus the regular dirtyness tracking mechanism do operate on such page. So page can go through: - GUPed by someone - write by CPU, mark as dirty - regular write-back kicks in - page is mark clean and fs might release data structure ... any amount of time ... what to do here if more CPU writes ? - GUPed user done and put_page but before call set_page_dirty() this might BUG_ON() inside fs code for some fs if the page was left clean on the CPU since last writeback I would strongly advise to read previous thread this was discussed at length. Cheers, Jérôme
