Re: [PATCH RFC v2 09/25] kmsan: add KMSAN runtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 30, 2019 at 3:23 PM <glider@xxxxxxxxxx> wrote:
>
> This patch adds the KernelMemorySanitizer runtime and associated files:
>
>   - arch/x86/include/asm/kmsan.h: assembly definitions for hooking
>     interrupt handlers;
>   - include/linux/kmsan-checks.h: user API to enable/disable KMSAN,
>     poison/unpoison memory etc.
>   - include/linux/kmsan.h: declarations of KMSAN memory hooks to be
>     referenced outside KMSAN runtime
>   - lib/Kconfig.kmsan: declarations for CONFIG_KMSAN and
>     CONFIG_TEST_KMSAN
>   - mm/kmsan/Makefile: boilerplate Makefile
>   - mm/kmsan/kmsan.h: internal KMSAN declarations
>   - mm/kmsan/kmsan.c: core functions that operate with shadow and
>     origin memory and perform checks, utility functions
>   - mm/kmsan/kmsan_entry.c: KMSAN hooks for entry_64.S
>   - mm/kmsan/kmsan_hooks.c: KMSAN hooks for kernel subsystems
>   - mm/kmsan/kmsan_init.c: KMSAN initialization routines
>   - mm/kmsan/kmsan_instr.c: functions called by KMSAN instrumentation
>   - scripts/Makefile.kmsan: CFLAGS_KMSAN
>
> Signed-off-by: Alexander Potapenko <glider@xxxxxxxxxx>
> To: Alexander Potapenko <glider@xxxxxxxxxx>
> Cc: Vegard Nossum <vegard.nossum@xxxxxxxxxx>
> Cc: Dmitry Vyukov <dvyukov@xxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx

>+                       kmsan_pr_err("Local variable description: %s\n", descr);
>+                       kmsan_pr_err("Variable was created at:\n");

It would be nice to tidy up the description, it contains lots of
duplicate/unneeded/confusing info:

Local variable description: ----br.i@vp7045_read_mac_addr
Variable was created at:
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132

It could be just:

Local variable br was created at:
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132
 vp7045_read_eeprom drivers/media/usb/dvb-usb/vp7045.c:119 [inline]
 vp7045_read_mac_addr+0x7b/0xbe0 drivers/media/usb/dvb-usb/vp7045.c:132




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux