> @@ -228,11 +228,11 @@ static int afs_xattr_get_yfs(const struct xattr_handler *handler, > break; > case 1: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->inherit_flag); > break; > case 2: > data = buf; > - dsize = snprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > + dsize = scnprintf(buf, sizeof(buf), "%u", yacl->num_cleaned); > break; > case 3: These scnprintf() changes (and there are more in the patch) probably shouldn't be here... Otherwise the patch still looks good to me :). Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
