Sorry for delay, On 05/12, Jiri Slaby wrote: > > We currently access current->comm directly. As we have > prctl(PR_SET_NAME), we need the access be protected by task_lock. This > is exactly what get_task_comm does, so use it. > > I'm not 100% convinced prctl(PR_SET_NAME) may be called at the time of > core dump, It can't be called. Apart from current, a sub-thread can change ->comm[] via /proc/pid/comm, but we already killed all threads. > but the locking won't hurt. Agreed, the patch looks correct. but still unneeded. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>