On Tue, Oct 29, 2019 at 10:04:45PM +0000, Kuehling, Felix wrote:
> > * because mm->mm_users > 0 during mmu_notifier_register and exit_mmap
> > @@ -52,17 +286,24 @@ struct mmu_notifier_mm {
> > * can't go away from under us as exit_mmap holds an mm_count pin
> > * itself.
> > */
> > -void __mmu_notifier_release(struct mm_struct *mm)
> > +static void mn_hlist_release(struct mmu_notifier_mm *mmn_mm,
> > + struct mm_struct *mm)
> > {
> > struct mmu_notifier *mn;
> > int id;
> >
> > + if (mmn_mm->has_interval)
> > + mn_itree_release(mmn_mm, mm);
> > +
> > + if (hlist_empty(&mmn_mm->list))
> > + return;
>
> This seems to duplicate the conditions in __mmu_notifier_release. See my
> comments below, I think one of them is wrong. I suspect this one,
> because __mmu_notifier_release follows the same pattern as the other
> notifiers.
Yep, this is a rebasing error from a earlier version, the above two
lines should be deleted.
I think it is harmless so it should not impact any testing.
Thanks,
Jason
