As syzbot reported, we cannot call filemap_flush() with the page locked.
Remove the filemap_flush() as it is not required. khugepaged would just
wait until the page is flushed naturally.
Reported-by: syzbot+efb9e48b9fbdc49bb34a@xxxxxxxxxxxxxxxxxxxxxxxxx
Fixes: 9d840e58caa0 ("mmthp-recheck-each-page-before-collapsing-file-thp-v4")
Cc: Johannes Weiner <hannes@xxxxxxxxxxx>
Cc: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
Cc: Hugh Dickins <hughd@xxxxxxxxxx>
Cc: William Kucharski <william.kucharski@xxxxxxxxxx>
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Song Liu <songliubraving@xxxxxx>
---
mm/khugepaged.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/mm/khugepaged.c b/mm/khugepaged.c
index cd480dce92c6..3ec5333ae94d 100644
--- a/mm/khugepaged.c
+++ b/mm/khugepaged.c
@@ -1640,16 +1640,8 @@ static void collapse_file(struct mm_struct *mm,
/*
* khugepaged only works on read-only fd, so this
* page is dirty because it hasn't been flushed
- * since first write. There won't be new dirty
- * pages.
- *
- * Trigger async flush here and hope the writeback
- * is done when khugepaged revisits this page.
- *
- * This is a one-off situation. We are not forcing
- * writeback in loop.
+ * since first write.
*/
- filemap_flush(mapping);
result = SCAN_FAIL;
goto out_unlock;
}
--
2.17.1
