On Mon, Oct 21, 2019 at 07:45:33AM +0000, Naoya Horiguchi wrote: > > +extern bool take_page_off_buddy(struct page *page); > > + > > +static void page_handle_poison(struct page *page) > > hwpoison is a separate idea from page poisoning, so maybe I think > it's better to be named like page_handle_hwpoison(). Yeah, that sounds better. > BTW, if we consider to make unpoison mechanism to keep up with the > new semantics, we will need the reverse operation of take_page_off_buddy(). > Do you think that that part will come with a separate work? Well, I am not really sure. Since we grab a refcount in page_handle_poison, all unpoison mechanism does is a "put_page", that should send the page back to buddy/pcp lists. I did not spot any problem when testing it, but I will double check. Thanks Naoya. -- Oscar Salvador SUSE L3
