On Mon, 16 May 2011 23:19:17 +0200, John Stultz wrote:
Now that accessing current->comm needs to be protected,
@@ -2868,6 +2868,10 @@ sub process {
WARN("usage of NR_CPUS is often wrong - consider using
cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" .
$herecurr);
}
+# check for current->comm usage
+ if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
Not a checkpatch.pl expert but as far as I'm concerned, that looks
reasonable.
I was sort of worried that t->comm could produce quite a few false
positives
but all its appearances in the kernel (seem to) refer to task.
+ WARN("comm access needs to be protected. Use get_task_comm, or
printk's \%ptc formatting.\n" . $herecurr);
+ }
# check for %L{u,d,i} in strings
my $string;
while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>