> > alloc_vmap_area() is given a gfp_mask for the page allocator. > > Let's respect that mask and consider it even in the case when > > doing regular CPU preloading, i.e. where a context can sleep. > > This is explaining what but it doesn't say why. I would go with > " > Allocation functions should comply with the given gfp_mask as much as > possible. The preallocation code in alloc_vmap_area doesn't follow that > pattern and it is using a hardcoded GFP_KERNEL. Although this doesn't > really make much difference because vmalloc is not GFP_NOWAIT compliant > in general (e.g. page table allocations are GFP_KERNEL) there is no > reason to spread that bad habit and it is good to fix the antipattern. > " I can go with that, agree. I am not sure if i need to update the patch and send v4. Or maybe Andrew can directly update it in his tree. Andrew, should i send or can update? Thank you in advance! -- Vlad Rezki
