Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: David Hildenbrand <david@xxxxxxxxxx>
Subject: Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
From: Michal Hocko <mhocko@xxxxxxxxxx>
Date: Wed, 16 Oct 2019 13:49:34 +0200
Cc: Anshuman Khandual <anshuman.khandual@xxxxxxx>, linux-mm@xxxxxxxxx, Mike Kravetz <mike.kravetz@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Vlastimil Babka <vbabka@xxxxxxx>, David Rientjes <rientjes@xxxxxxxxxx>, Andrea Arcangeli <aarcange@xxxxxxxxxx>, Oscar Salvador <osalvador@xxxxxxx>, Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>, Mike Rapoport <rppt@xxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Pavel Tatashin <pavel.tatashin@xxxxxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <eb2406d5-1327-1365-be0e-ee319ab92088@redhat.com>
References: <1571211293-29974-1-git-send-email-anshuman.khandual@arm.com> <c7ac9f99-a34f-c553-b216-b847d093cae9@redhat.com> <20191016085123.GO317@dhcp22.suse.cz> <679b5c66-8f1b-ec4d-64dd-13fbc440917d@redhat.com> <20191016110831.GV317@dhcp22.suse.cz> <eb2406d5-1327-1365-be0e-ee319ab92088@redhat.com>
User-agent: Mutt/1.10.1 (2018-07-13)

On Wed 16-10-19 13:10:41, David Hildenbrand wrote:
> On 16.10.19 13:08, Michal Hocko wrote:
> > On Wed 16-10-19 10:56:16, David Hildenbrand wrote:
[...]
> > > Gigantic pages have to be aligned AFAIK.
> > 
> > Aligned to what? I do not see any guarantee like that in the existing
> > code.
> > 
> 
> pfn = ALIGN(zone->zone_start_pfn, nr_pages);

I am obviously blind! Sorry about the confusion.

-- 
Michal Hocko
SUSE Labs

References:
- [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: Anshuman Khandual
- Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: David Hildenbrand
- Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: Michal Hocko
- Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: David Hildenbrand
- Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: Michal Hocko
- Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
  - From: David Hildenbrand

Prev by Date: Re: [PATCH 7/8] locking/atomics, kcsan: Add KCSAN instrumentation
Next by Date: Re: [PATCH 1/8] kcsan: Add Kernel Concurrency Sanitizer infrastructure
Previous by thread: Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
Next by thread: Re: [PATCH] mm/page_alloc: Make alloc_gigantic_page() available for general use
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Bugtraq] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]