On (10/14/19 13:52), Vitaly Wool wrote: > On Mon, Oct 14, 2019 at 12:49 PM Sergey Senozhatsky > <sergey.senozhatsky.work@xxxxxxxxx> wrote: > > > > On (10/10/19 23:20), Vitaly Wool wrote: > > [..] > > > static const char *default_compressor = "lzo-rle"; > > > > > > +#define BACKEND_PAR_BUF_SIZE 32 > > > +static char backend_par_buf[BACKEND_PAR_BUF_SIZE]; > > > > We can have multiple zram devices (zram0 .. zramN), I guess it > > would make sense not to force all devices to use one particular > > allocator (e.g. see comp_algorithm_store()). > > > > If the motivation for the patch set is that zsmalloc does not > > perform equally well for various data access patterns, then the > > same is true for any other allocator. Thus, I think, we need to > > have a per-device 'allocator' knob. > > We were thinking here in per-SoC terms basically, but this is a valid > point. Since zram has a well-established sysfs per-device > configuration interface, backend choice better be moved there. Agree? Yup, sysfs per-device knob. // Given that Minchan is OK with the patch set. -ss
