On Sun, 15 May 2011 12:56:00 -0700 Greg Thelen <gthelen@xxxxxxxxxx> wrote: > On Fri, May 13, 2011 at 2:56 AM, KAMEZAWA Hiroyuki > <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote: > > On Fri, 13 May 2011 01:47:49 -0700 > > Greg Thelen <gthelen@xxxxxxxxxx> wrote: > >> +static unsigned long mem_cgroup_page_stat(struct mem_cgroup *mem, > >> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â enum mem_cgroup_page_stat_item item) > > > > How about mem_cgroup_file_cache_stat() ? > > The suggested rename is possible. But for consistency I assume we > would also want to rename: > * mem_cgroup_local_page_stat() > * enum mem_cgroup_page_stat_item > * mem_cgroup_update_page_stat() > * mem_cgroup_move_account_page_stat() > Yes, maybe clean up is necessary. > I have a slight preference for leaving it as is, > mem_cgroup_page_stat(), to allow for future coverage of pages other > that just file cache pages. But I do not feel very strongly. > ok, I'm not have big concern on naming for now. please do as you like. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>