On Wed 09-10-19 21:56:04, Yizhuo Zhai wrote: > Hi All: > mm/memcontrol.c: > The function mem_cgroup_from_css() could return NULL, but some callers This is the case only when the memory cgroup controller is disabled which is a boot time option. > in this file > checks the return value but directly dereference it, which seems > potentially unsafe. > Such callers include mem_cgroup_hierarchy_read(), > mem_cgroup_hierarchy_write(), mem_cgroup_read_u64(), > mem_cgroup_reset(), etc. And none of those should be ever called under that condition AFAICS. Thanks! -- Michal Hocko SUSE Labs
