On 10/9/19 6:23 PM, Wei Yang wrote: > On Wed, Oct 09, 2019 at 05:45:57PM -0700, Mike Kravetz wrote: >> On 10/9/19 5:27 AM, YueHaibing wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb': >>> mm/userfaultfd.c:217:17: warning: >>> variable 'h' set but not used [-Wunused-but-set-variable] >>> >>> It is not used since commit 78911d0e18ac ("userfaultfd: use vma_pagesize >>> for all huge page size calculation") >>> >> >> Thanks! That should have been removed with the recent cleanups. >> >>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> >> >> Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx> > > If I am correct, this is removed in a recent patch. I'm having a hard time figuring out what is actually in the latest mmotm tree. Andrew added a build fixup patch ab169389eb5 in linux-next which adds the reference to h. Is there a patch after that to remove the reference? -- Mike Kravetz