On Tue 08-10-19 19:06:57, Cristopher Lameter wrote: > On Sat, 28 Sep 2019, Kaitao Cheng wrote: > > > There is no need to make the 'node_order' variable static > > since new value always be assigned before use it. > > In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large > array allocations on the stack are problematic. > > Maybe that is no longer the case? CONFIG_NODES_SHIFT=10 is nothing really unusual in distribution kernels. Likely wasteful for most HW available but a proper way to address it in this particular case is to use a different data structure than drop the static modifier which seems to be more of an misunderstanding than an intention. -- Michal Hocko SUSE Labs
