The linux-next commit "mm/z3fold.c: add inter-page compaction" [1] introduced a few GCC compilation warnings. mm/z3fold.c: In function 'compact_single_buddy': mm/z3fold.c:693:16: warning: variable 'newpage' set but not used [-Wunused-but-set-variable] struct page *newpage; ^~~~~~~ mm/z3fold.c:664:13: warning: variable 'bud' set but not used [-Wunused-but-set-variable] enum buddy bud; ^~~ Simply remove those seems accidentally left-over code. [1] http://lkml.kernel.org/r/20191006041457.24113-1-vitalywool@xxxxxxxxx Signed-off-by: Qian Cai <cai@xxxxxx> --- mm/z3fold.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mm/z3fold.c b/mm/z3fold.c index 25713a4a7186..d48d0ec3bcdd 100644 --- a/mm/z3fold.c +++ b/mm/z3fold.c @@ -661,7 +661,6 @@ static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr) struct z3fold_pool *pool = zhdr_to_pool(zhdr); void *p = zhdr; unsigned long old_handle = 0; - enum buddy bud; size_t sz = 0; struct z3fold_header *new_zhdr = NULL; int first_idx = __idx(zhdr, FIRST); @@ -673,24 +672,20 @@ static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr) * the page lock is already taken */ if (zhdr->first_chunks && zhdr->slots->slot[first_idx]) { - bud = FIRST; p += ZHDR_SIZE_ALIGNED; sz = zhdr->first_chunks << CHUNK_SHIFT; old_handle = (unsigned long)&zhdr->slots->slot[first_idx]; } else if (zhdr->middle_chunks && zhdr->slots->slot[middle_idx]) { - bud = MIDDLE; p += zhdr->start_middle << CHUNK_SHIFT; sz = zhdr->middle_chunks << CHUNK_SHIFT; old_handle = (unsigned long)&zhdr->slots->slot[middle_idx]; } else if (zhdr->last_chunks && zhdr->slots->slot[last_idx]) { - bud = LAST; p += PAGE_SIZE - (zhdr->last_chunks << CHUNK_SHIFT); sz = zhdr->last_chunks << CHUNK_SHIFT; old_handle = (unsigned long)&zhdr->slots->slot[last_idx]; } if (sz > 0) { - struct page *newpage; enum buddy new_bud = HEADLESS; short chunks = size_to_chunks(sz); void *q; @@ -699,7 +694,6 @@ static struct z3fold_header *compact_single_buddy(struct z3fold_header *zhdr) if (!new_zhdr) return NULL; - newpage = virt_to_page(new_zhdr); if (WARN_ON(new_zhdr == zhdr)) goto out_fail; -- 1.8.3.1