On Fri, May 13, 2011 at 03:03:21PM +0100, Mel Gorman wrote: > Johannes Weiner poined out that the logic in commit [1741c877: mm: > kswapd: keep kswapd awake for high-order allocations until a percentage > of the node is balanced] is backwards. Instead of allowing kswapd to go > to sleep when balancing for high order allocations, it keeps it kswapd > running uselessly. > > From-but-was-not-signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> Thanks for picking it up, Mel. Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx> > Will-sign-off-after-Johannes: Mel Gorman <mgorman@xxxxxxx> > --- > mm/vmscan.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index f6b435c..af24d1e 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2286,7 +2286,7 @@ static bool sleeping_prematurely(pg_data_t *pgdat, int order, long remaining, > * must be balanced > */ > if (order) > - return pgdat_balanced(pgdat, balanced, classzone_idx); > + return !pgdat_balanced(pgdat, balanced, classzone_idx); > else > return !all_zones_ok; > } > -- > 1.7.3.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>