Re: [PATCH 06/15] xfs: Pass a page to xfs_finish_page_writeback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 5 Oct 2019 03:35:36 +0800 Matthew Wilcox wrote:
> 
> On Thu, Oct 03, 2019 at 12:08:46PM +0800, Hillf Danton wrote:
> >
> > On Tue, 24 Sep 2019 17:52:02 -0700 From: Matthew Wilcox (Oracle)
> > >
> > > The only part of the bvec we were accessing was the bv_page, so just
> > > pass that instead of the whole bvec.
> >
> > Change is added in ABI without a bit of win.
> > Changes like this are not needed.
> 
> ABI?  This is a static function.  The original recommendation to do this
> came from Christoph, who I would trust over you as a referee of what
> changes to make to XFS.

Hehe, I try to see your point, nice code will never be able to
escape standing ovation.





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux