On 03/10/19 23:23, Rick Edgecombe wrote: > +/* KVM based not-readable: only valid after cpuid check */ > +#define _PAGE_BIT_NR (__pgtable_kvmxo_bit) > +#else /* defined(CONFIG_KVM_XO) && !defined(__ASSEMBLY__) */ > +#define _PAGE_BIT_NR 0 > +#endif /* defined(CONFIG_KVM_XO) && !defined(__ASSEMBLY__) */ Please do not #define _PAGE_BIT_NR and _PAGE_NR, so that it's clear that they are variables. Paolo