On 10/03/2019 04:49 PM, Qian Cai wrote: > > >> On Oct 3, 2019, at 5:32 AM, Anshuman Khandual <Anshuman.Khandual@xxxxxxx> wrote: >> >> Even though page flags does contain reserved bit information, the problem >> is that we are explicitly printing the reason for this page dump. In this >> case it is caused by the fact that it is a reserved page. >> >> page dumped because: <reason> >> >> The proposed change makes it explicit that the dump is caused because a >> non movable page with reserved bit set. It also helps in differentiating >> between reserved bit condition and the last one "if (found > count)". > > Then, someone later would like to add a reason for every different page flags just because they *think* they are special. > Ohh, never meant that the 'Reserved' bit is anything special here but it is a reason to make a page unmovable unlike many other flags.